system/network: Fix interfaces filtering #15883
Merged
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes network data stream interface filtering by populating both the legacy top-level interfaces field and the nested network.interfaces field to maintain backward compatibility with existing Beats behavior.
- Version bumped to 2.7.1
- Added dual population of
interfacesandnetwork.interfacesfields in the stream template - Improved documentation clarity for the network interfaces configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/system/manifest.yml | Bumped version to 2.7.1 for the bugfix release |
| packages/system/data_stream/network/manifest.yml | Improved description clarity for interface monitoring behavior |
| packages/system/data_stream/network/agent/stream/stream.yml.hbs | Added legacy interfaces field alongside network.interfaces to fix filtering |
| packages/system/changelog.yml | Documented the bugfix with link to PR |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/system/data_stream/network/agent/stream/stream.yml.hbs
Outdated
Show resolved
Hide resolved
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
syslog |
500000 | 250000 | -250000 (-50%) | 💔 |
To see the full report comment with /test benchmark fullreport
andrewkroh
added
Integration:system
Co-authored-by: Copilot <[email protected]>
💚 Build Succeeded
History
cc @shmsr |
ishleenk17
approved these changes
Nov 7, 2025
|
Package system - 2.7.1 containing this change is available at https://epr.elastic.co/package/system/2.7.1/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
So far interfaces added by the user were populating
network.interfacesbut that does not populate the list internally as the config is at module level and not at metricset level; so instead of configuringnetwork.interfaces, one must configureinterfacesand it will populate the list of interfaces and it will work as expected.Checklist
changelog.ymlfile.How to test this PR locally
When configured, in debug mode, the code should trigger:
^ Implementation in beats
So, with this fix, I am able to get the right interfaces configured.